Skip to content

Attempt to fix DD malformed version #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

joelim41
Copy link

@joelim41 joelim41 commented Jun 3, 2025

We saw a small percentage of requests with malformed version tag. This is likely caused by ddtrace removing the version tag for spans that are not using the default service name - DataDog#4027. This change restores the previous behavior.

Copy link

github-actions bot commented Jun 3, 2025

👋 Hey @DataDog/ruby-guild, please fill "Change log entry" section in the pull request description.

If changes need to be present in CHANGELOG.md you can state it this way

**Change log entry**

Yes. A brief summary to be placed into the CHANGELOG.md

(possible answers Yes/Yep/Yeah)

Or you can opt out like that

**Change log entry**

None.

(possible answers No/Nope/None)

Visited at: 2025-06-03 16:22:22 UTC

@joelim41 joelim41 marked this pull request as ready for review June 3, 2025 16:20
@joelim41 joelim41 requested a review from a team as a code owner June 3, 2025 16:20
Copy link

@jasonpenny jasonpenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rather than diverging even further from upstream, have you tried following the docs and setting configuration.version?

https://docs.datadoghq.com/tracing/trace_collection/automatic_instrumentation/dd_libraries/ruby/

image

@joelim41
Copy link
Author

joelim41 commented Jun 3, 2025

rather than diverging even further from upstream, have you tried following the docs and setting configuration.version?

https://docs.datadoghq.com/tracing/trace_collection/automatic_instrumentation/dd_libraries/ruby/

image

I looked into the code, it seems that these are treated the same:

But it should be low effort to test it out, so I created a PR for this - https://github.com/Appboy/platform/pull/99481

@joelim41 joelim41 requested a review from jasonpenny June 3, 2025 19:11
Copy link

@jasonpenny jasonpenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still seeing requests with malformed version after deploying Appboy/platform#99481

there's no real reason why this upgrade has to go out now, right?
so I think we need to

  • figure out why this code exists upstream, Parity with other tracing clients from the linked PR doesn't really explain why
  • ask the maintainers for a way to avoid this behavior (or open a PR ourselves to do so) - in general, we should try to avoid forking and diverging further

@joelim41 joelim41 closed this Jun 3, 2025
@joelim41
Copy link
Author

joelim41 commented Jun 3, 2025

DataDog#4707 issue filed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants